Repository navigation
Conversation
|
/submit |
|
Submitted as pull.131.git.gitgitgadget@gmail.com |
This is a brown paper bag. When adding the tests, we actually failed to verify that the config variable is heeded in git-init at all. And when changing the original patch that marked the .git/ directory as hidden after reading the config, it was lost on this developer that the new code would use the hide_dotfiles variable before the config was read. The fix is obvious: read the (limited, pre-init) config *before* creating the .git/ directory. Please note that we cannot remove the identical-looking `git_config()` call from `create_default_files()`: we create the `.git/` directory between those calls. If we removed it, and if the parent directory is in a Git worktree, and if that worktree's `.git/config` contained any `init.templatedir` setting, we would all of a sudden pick that up. This fixes git-for-windows#789 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/submit |
|
Submitted as pull.131.v2.git.gitgitgadget@gmail.com |
|
This branch is now known as |
|
This patch series was integrated into pu via git@b2b8028. |
|
This patch series was integrated into pu via git@e907134. |
|
This patch series was integrated into pu via git@244a95b. |
|
This patch series was integrated into pu via git@980d11e. |
|
This patch series was integrated into pu via git@bc7ca16. |
|
This patch series was integrated into pu via git@521a344. |
|
This patch series was integrated into pu via git@d0a9f6c. |
|
This patch series was integrated into pu via git@cb17ca7. |
|
This patch series was integrated into pu via git@597fe3f. |
|
This patch series was integrated into pu via git@e539234. |
|
This patch series was integrated into next via git@1d57688. |
|
This patch series was integrated into pu via git@6364386. |
|
This patch series was integrated into next via git@6364386. |
|
This patch series was integrated into master via git@6364386. |
|
Closed via 6364386. |
Update clar to commit 39f11fe (Merge pull request #131 from pks-gitlab/pks-integer-double-evaluation, 2025-12-05). This commit includes the following changes relevant to Git: - There are now typesafe integer comparison functions. Furthermore, the range of comparison functions has been included to also have relative comparisons, like "greater than". - There is a new `cl_failf()` macro that allows the caller to specify an error message with formatting directives. - The TAP format has been fixed to correctly terminate YAML blocks with "...\n" instead of "---\n". Note that we already had a `cl_failf()` function declared in our own sources. This function is equivalent to the upstreamed function, so we can simply drop it now. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This fixes an regression that was not present in Git for Windows's original
core.hideDotFilespatch, but in the shape of thecore.hideDotFilespatch that made it into git.git.We fixed it in one big hurry in Git for Windows, and I simply forgot to upstream this right away.
Changes since v1:
core.hidedotfilesin the firstgit_config()call.git_config(git_init_db_config, NULL)call fromcreate_default_files(): it would cause a change of behavior with regard to theinit.templatedirsetting.